Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress status updating should respect ingress class #2388

Closed
youngnick opened this issue Mar 26, 2020 · 0 comments · Fixed by #2416
Closed

Ingress status updating should respect ingress class #2388

youngnick opened this issue Mar 26, 2020 · 0 comments · Fixed by #2416
Assignees
@youngnick
Labels
area/ingress Issues or PRs related to the Ingress API.

Comments

@youngnick
Copy link
Member

After #2386, Ingresses will have status added, but it currently does not respect the Ingress class annotation. This issue covers fixing that issue.

xref #403
@youngnick youngnick added the area/ingress Issues or PRs related to the Ingress API. label Mar 26, 2020
@youngnick youngnick self-assigned this Mar 26, 2020
This was referenced Mar 26, 2020
Closed
Merged
youngnick added a commit to youngnick/contour that referenced this issue Apr 2, 2020
@youngnick
internal/k8s: Refactor annotations code from internal/dag
2651bf3 
Updates projectcontour#2388
Update projectcontour#403

Refactor annotations code from internal/dag into internal/k8s so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (Object and Meta) into
k8s from dag.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 2, 2020
@youngnick
internal/k8s: Refactor annotations code from internal/dag
51759ae 
Updates projectcontour#2388
Update projectcontour#403

Refactor annotations code from internal/dag into internal/k8s so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (Object and Meta) into
k8s from dag.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 2, 2020
@youngnick
internal/k8s: Refactor annotations code from internal/dag
2040562 
Updates projectcontour#2388
Update projectcontour#403

Refactor annotations code from `internal/dag` into `internal/k8s` so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (`Object` and `Meta`) into
`k8s` from `dag`.

Signed-off-by: Nick Young <ynick@vmware.com>
@youngnick youngnick mentioned this issue Apr 2, 2020
Merged
youngnick added a commit to youngnick/contour that referenced this issue Apr 2, 2020
@youngnick
internal/annotation: Refactor annotations code from internal/dag
bc273e5 
Updates projectcontour#2388
Update projectcontour#403

Refactor annotations code from `internal/dag` into `internal/annotation` so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (`Object` and `Meta`) into
`k8s` from `dag`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 3, 2020
@youngnick
internal/annotation: Refactor annotations code from internal/dag
bfc6c70 
Updates projectcontour#2388
Update projectcontour#403

Refactor annotations code from `internal/dag` into `internal/annotation` so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (`Object` and `Meta`) into
`k8s` from `dag`. `Meta` has also been renamed to `FullName` for greater clarity.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit that referenced this issue Apr 3, 2020
@youngnick
internal/annotation: Refactor annotations code from internal/dag (#2412)
4864061 
Updates #2388
Update #403

Refactor annotations code from `internal/dag` into `internal/annotation` so that
code dealing with ingress status will be able to use it.

This includes moving some generic Kubernetes structs (`Object` and `Meta`) into
`k8s` from `dag`. `Meta` has also been renamed to `FullName` for greater clarity.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 6, 2020
@youngnick
Add ingress class filtering to ingress status updating
28af629 
Fixes projectcontour#2388
Updates projectcontour#403

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 6, 2020
@youngnick
Add ingress class filtering to ingress status updating
2a43265 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater`

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 6, 2020
@youngnick
Add ingress class filtering to ingress status updating
348da05 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
@youngnick youngnick mentioned this issue Apr 6, 2020
Merged
youngnick added a commit to youngnick/contour that referenced this issue Apr 6, 2020
@youngnick
Add ingress class filtering to ingress status updating
d55bf02 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 6, 2020
@youngnick
Add ingress class filtering to ingress status updating
86d94bf 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 7, 2020
@youngnick
Add ingress class filtering to ingress status updating
994bc39 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 7, 2020
@youngnick
Add ingress class filtering to ingress status updating
47776ca 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 7, 2020
@youngnick
Add ingress class filtering to ingress status updating
c47550c 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 7, 2020
@youngnick
Add ingress class filtering to ingress status updating
f265a92 
Fixes projectcontour#2388
Updates projectcontour#403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit that referenced this issue Apr 7, 2020
@youngnick
Add ingress class filtering to ingress status updating (#2416)
0b24e04 
Fixes #2388
Updates #403

Move annotations to use upstream `ObjectMetaAccessor` instead of `k8s.Object`, removes an import cycle.

Copy `KindOf` from k8s to `annotations_test.go` for use in the tests only, also prevents and import cycle.

Move `ParseTimeout` from `k8s` to `annotation` for now as well, more import cycles.

Move ingress class matching code from `dag` to `annotation`, so it's only in one place.

Add ingress class filtering to `k8s.IngressStatusUpdater` `OnAdd` and `OnUpdate`.

Signed-off-by: Nick Young <ynick@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngnick youngnick

Labels
area/ingress Issues or PRs related to the Ingress API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ingress class filtering to ingress status updating youngnick/contour
1 participant
@youngnick