Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioner fails when the Gateway name is longer than 63 characters #5970

Open
skriss opened this issue Nov 16, 2023 · 6 comments
Open

provisioner fails when the Gateway name is longer than 63 characters #5970

skriss opened this issue Nov 16, 2023 · 6 comments
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@skriss
Copy link
Member

skriss commented Nov 16, 2023

What steps did you take and what happened:
Create a Gateway with a name longer than 63 characters
Observe that no resources are created, errors in the logs

The problem is that we set some labels on resources based on the Gateway name, but Gateway names can be up to 253 characters while labels can be at most 63. We need some kind of hashing to handle longer names.

@skriss skriss added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. area/gateway-provisioner Issues or PRs related to the Gateway provisioner labels Nov 16, 2023
@sunjayBhatia sunjayBhatia added this to the 1.28.0 milestone Nov 17, 2023
@sunjayBhatia
Copy link
Member

There is a new test in Gateway conformance that adds a Gateway with a long name, adding to the next milestone so we're aware for the next bump

@skriss
Copy link
Member Author

skriss commented Nov 17, 2023

One thing we may want to bring upstream here: GEP-1762 calls for labeling in-cluster Gateway resources (ref. https://gateway-api.sigs.k8s.io/geps/gep-1762/#automated-deployments) in the same way that Contour already does with its own custom label, but doesn't describe what to do in this scenario where the Gateway name is too long. That should probably be part of the spec.

@sunjayBhatia
Copy link
Member

ah yeah that is a very good point, I forgot that GEP specifically adds the gateway name as a label, definitely something to bring up to the community

@sunjayBhatia
Copy link
Member

added kubernetes-sigs/gateway-api#2592

@skriss
Copy link
Member Author

skriss commented Jan 29, 2024

TODO add a note to Contour Gateway API docs about this open issue

@skriss skriss self-assigned this Jan 29, 2024
skriss added a commit to skriss/contour that referenced this issue Jan 29, 2024
Updates projectcontour#5970.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss added a commit to skriss/contour that referenced this issue Jan 29, 2024
Updates projectcontour#5970.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jan 29, 2024
@skriss skriss removed this from the 1.28.0 milestone Jan 29, 2024
@skriss skriss added the blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. label Jan 29, 2024
@skriss
Copy link
Member Author

skriss commented Jan 29, 2024

Added a docs PR to document this for Contour; awaiting resolution of upstream issue, hopefully with guidance on how implementations should handle this situation.

@skriss skriss removed their assignment Jan 29, 2024
skriss added a commit that referenced this issue Jan 29, 2024
Updates #5970.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: No status
Development

No branches or pull requests

2 participants