Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: document Gateway name length limit #6143

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

skriss
Copy link
Member

@skriss skriss commented Jan 29, 2024

Updates #5970.

Updates projectcontour#5970.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss added the release-note/docs A documentation change for the release notes. label Jan 29, 2024
@skriss skriss requested a review from a team as a code owner January 29, 2024 20:11
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team January 29, 2024 20:11
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team January 29, 2024 20:12
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4619e0a) 78.81% compared to head (ba7bd45) 78.81%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6143   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         138      138           
  Lines       19790    19790           
=======================================
  Hits        15597    15597           
  Misses       3884     3884           
  Partials      309      309           
Files Coverage Δ
cmd/contour/gatewayprovisioner.go 43.87% <100.00%> (ø)

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss merged commit 54fc8fc into projectcontour:main Jan 29, 2024
26 checks passed
@skriss skriss deleted the pr-gw-name-limit branch January 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants