Fix the build for units tests. #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
approved these changes
Mar 19, 2020
youngnick
approved these changes
Mar 19, 2020
We need to not include hack in the `go test` build, since that causes `main` to be defined multiple times. Signed-off-by: James Peach <jpeach@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
+ Coverage 77.24% 77.97% +0.73%
==========================================
Files 62 60 -2
Lines 5256 5204 -52
==========================================
- Hits 4060 4058 -2
+ Misses 1109 1058 -51
- Partials 87 88 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to not include hack in the
go testbuild, since that causesmainto be defined multiple times.Signed-off-by: James Peach jpeach@vmware.com