internal/envoy: Refactor the regex file into the v2 package #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matcher package is for v2 xDS resource APIs, so needs to be in the internal/envoy/v2 package. Signed-off-by: Steve Sloka <slokas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #3081 +/- ##
=======================================
Coverage 73.99% 73.99%
=======================================
Files 101 101
Lines 6280 6280
=======================================
Hits 4647 4647
Misses 1530 1530
Partials 103 103
|
skriss
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matcher package is for v2 xDS resource APIs, so needs to be in the internal/envoy/v2 package.
Signed-off-by: Steve Sloka slokas@vmware.com