-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdditionalPrinterColumns to IngressRoute CRD spec #618
Conversation
Given ingressroutes:
Getting IngressRoutes results in:
|
06b6b13
to
e2ed840
Compare
This is ready for review, but not critical for 0.6.0-beta3 - OK to leave to 0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm fine if @stevesloka is +1
@rosskukulinski could you rebase this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
e2ed840
to
d865637
Compare
Related to projectcontour/contour#618 Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Signed-off-by: Ross Kukulinski <ross@kukulinski.com> Add additionalColumns to CRD defintion. Related to projectcontour/contour#618 Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Signed-off-by: Ross Kukulinski <ross@kukulinski.com> Add additionalColumns to CRD defintion. Related to projectcontour/contour#618 Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
Fixes #617.
I have tested to ensure that this doesn't break anything for Kubernetes API or kubectl <1.11
Signed-off-by: Ross Kukulinski ross@kukulinski.com