Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdditionalPrinterColumns to IngressRoute CRD spec #618

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

rosskukulinski
Copy link
Contributor

@rosskukulinski rosskukulinski commented Aug 11, 2018

Fixes #617.

I have tested to ensure that this doesn't break anything for Kubernetes API or kubectl <1.11

Signed-off-by: Ross Kukulinski ross@kukulinski.com

@rosskukulinski
Copy link
Contributor Author

Given ingressroutes:

apiVersion: v1
items:
- apiVersion: contour.heptio.com/v1beta1
  kind: IngressRoute
  metadata:
    name: apps
    namespace: default
  spec:
    routes:
    - match: /
      services:
      - name: apps
        port: 80
    virtualhost:
      fqdn: apps.heptio.com
- apiVersion: contour.heptio.com/v1beta1
  kind: IngressRoute
  metadata:
    name: blog
    namespace: default
  spec:
    routes:
    - match: /blog
      services:
      - name: blog
        port: 80
- apiVersion: contour.heptio.com/v1beta1
  kind: IngressRoute
  metadata:
    name: heptio
    namespace: default
  spec:
    routes:
    - match: /
      services:
      - name: kuard
        port: 80
    - match: /blog
      delegate:
        name: blog
    virtualhost:
      aliases:
      - www.heptio.com
      fqdn: heptio.com
      tls:
        secretName: heptio-tls
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Getting IngressRoutes results in:

$ kubectl get ingressroute
NAME      FQDN              ALIASES            TLS SECRET   FIRST ROUTE   STATUS    STATUS DESCRIPTION
apps      apps.heptio.com                                   /             valid     valid IngressRoute
blog                                                        /blog         valid     valid IngressRoute
heptio    heptio.com        [www.heptio.com]   heptio-tls   /             valid     valid IngressRoute

@rosskukulinski rosskukulinski changed the title Add AdditionalPrinterColumns to IngressRoute CRD spec DO NOT MERGE: Add AdditionalPrinterColumns to IngressRoute CRD spec Aug 11, 2018
@rosskukulinski rosskukulinski changed the title DO NOT MERGE: Add AdditionalPrinterColumns to IngressRoute CRD spec Add AdditionalPrinterColumns to IngressRoute CRD spec Aug 13, 2018
@rosskukulinski rosskukulinski added this to the 0.6.0 milestone Aug 13, 2018
@rosskukulinski
Copy link
Contributor Author

This is ready for review, but not critical for 0.6.0-beta3 - OK to leave to 0.6.0

davecheney
davecheney previously approved these changes Aug 14, 2018
Copy link
Contributor

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm fine if @stevesloka is +1

@davecheney davecheney modified the milestones: 0.6.0, 0.6.0-beta.3 Aug 14, 2018
@davecheney davecheney dismissed their stale review August 15, 2018 09:29

LGTM. Leaving for Steve

@stevesloka
Copy link
Member

@rosskukulinski could you rebase this please?

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
@rosskukulinski rosskukulinski merged commit 4f92758 into master Aug 15, 2018
rosskukulinski added a commit to projectcontour/gimbal that referenced this pull request Aug 15, 2018
Related to projectcontour/contour#618

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
rosskukulinski added a commit to projectcontour/gimbal that referenced this pull request Aug 17, 2018
Signed-off-by: Ross Kukulinski <ross@kukulinski.com>

Add additionalColumns to CRD defintion.
Related to projectcontour/contour#618

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
rosskukulinski added a commit to projectcontour/gimbal that referenced this pull request Aug 17, 2018
Signed-off-by: Ross Kukulinski <ross@kukulinski.com>

Add additionalColumns to CRD defintion.
Related to projectcontour/contour#618

Signed-off-by: Ross Kukulinski <ross@kukulinski.com>
@davecheney davecheney deleted the additionalColumns branch April 9, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants