-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record sample now populates input with code value #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works, just have one comment on one of the variables.
EDIT: Actually, one more thing: when you click on a code when there are multiple options, the modal disappears (as it should), but when there's only one option, it doesn't disappear. It's a strange behavioral inconsistency.
@@ -11,7 +11,7 @@ | |||
<% if !hide_patient_calculation? %> | |||
<div id='modify_record'><button class='btn btn-default' type='button' id="modifyrecord">Edit Test</button></div> | |||
<% end %> | |||
<% measures.sort_by(&:cms_int).each.with_index do |measure, measure_index| %> | |||
<% @measures.sort_by(&:cms_int).each do |measure, measure_index| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for the replacing the local variable with an instance variable? (measures
to @measures
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to @ljades, I found that clicking on a code when the list only has 1 element doesn't dismiss the modal for some reason.
81b2b54
to
1f3e8ef
Compare
26a3b60
to
eb4608b
Compare
On the record sample form user can now click on a code from the record sample modal that pops up when code set button is clicked and that code will be populated in the input box associated with that value set.
Submitter: Laura Clark
Reviewer 1: Michael O'Keefe
Name:
Reviewer 2:
Name: