Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(potential) SIGV err #175

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(potential) SIGV err #175

merged 2 commits into from
Sep 22, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir self-assigned this Sep 13, 2023
tarunKoyalwar
tarunKoyalwar requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm!

failing test

@tarunKoyalwar tarunKoyalwar linked an issue Sep 21, 2023 that may be closed by this pull request
segmentation violation error projectdiscovery/httpx#1348
Closed
@ehsandeep ehsandeep merged commit 34c11bd into dev Sep 22, 2023
2 checks passed
@ehsandeep ehsandeep deleted the fix_segv_err branch September 22, 2023 13:59
@chenrui333 chenrui333 mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segmentation violation error
3 participants
@dogancanbakir @tarunKoyalwar @ehsandeep