fix(potential) SIGV err

libs/client.go

@@ -23,7 +23,7 @@ const serverURL = "https://api.asnmap.sh/"
 
 type Client struct {
 	url  *url.URL
-	http http.Client
+	http *http.Client
 }
 
 // generatefullURL creates the complete URL with path, scheme, and host
@@ -34,7 +34,7 @@ func generateFullURL(host string) (*url.URL, error) {
 	}
 
 	if !stringsutil.EqualFoldAny(rawURL.Scheme, "http", "https") {
-		return nil, errors.New("Host should start with http or https.")
+		return nil, errors.New("host should start with http or https")
 	}
 
 	rawURL.Path = "api/v1/asnmap"
@@ -63,7 +63,7 @@ func NewClient() (*Client, error) {
 
 	client := Client{
 		url:  URL,
-		http: http.Client{Transport: transCfg},
+		http: &http.Client{Transport: transCfg},
 	}
 	return &client, nil
 }
@@ -149,14 +149,24 @@ func generateRawQuery(query, value string) string {
 }
 
 func (c Client) makeRequest() ([]byte, error) {
-	req, _ := http.NewRequest(http.MethodGet, c.url.String(), nil)
+	if c.http == nil {
+		return nil, errors.New("http client is not initialized")
+	}
+
+	req, err := http.NewRequest(http.MethodGet, c.url.String(), nil)
+	if err != nil {
+		return nil, err
+	}
 	res, err := c.http.Do(req)
 	if err != nil {
 		return nil, err
 	}
 	defer res.Body.Close()
 
-	resBody, _ := io.ReadAll(res.Body)
+	resBody, err := io.ReadAll(res.Body)
+	if err != nil {
+		return nil, err
+	}
 	return resBody, nil
 }
 

runner/runner_test.go

@@ -1,6 +1,7 @@
 package runner
 
 import (
+	"fmt"
 	"testing"
 
 	asnmap "github.com/projectdiscovery/asnmap/libs"
@@ -21,12 +22,12 @@ func TestRunner(t *testing.T) {
 			},
 			expectedOutput: []*asnmap.Response{
 				{
-					FirstIp: "102.129.206.0",
-					LastIp:  "127.255.255.255",
+					FirstIp: "104.16.0.0",
+					LastIp:  "104.21.127.255",
 					Input:   "104.16.99.52",
-					ASN:     9498,
-					Country: "IN",
-					Org:     "BBIL-AP BHARTI Airtel Ltd."},
+					ASN:     13335,
+					Country: "US",
+					Org:     "CLOUDFLARENET"},
 			},
 		},
 		{
@@ -69,8 +70,9 @@ func TestRunner(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			fmt.Println(tt.name)
 			tt.options.OnResult = func(o []*asnmap.Response) {
-				require.Equal(t, o, tt.expectedOutput)
+				require.Equal(t, tt.expectedOutput, o)
 			}
 			r, err := New(tt.options)
 			require.Nil(t, err)