Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring output file flush logic #202

Merged
merged 1 commit into from
May 10, 2022
Merged

Refactoring output file flush logic #202

merged 1 commit into from
May 10, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 9, 2022 •
edited

Description

This PR simplifies and fix the output file flush logic for large volumes of data

How to reproduce

$ wc -l list.txt 
 10000000 list.txt
$ cat list.txt | go run . -silent -o output.txt -t 10000 | tee output_tee.txt
...
$ wc -l output.txt output_tee.txt 
 8909606 output.txt
 8909606 output_tee.txt

@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels May 9, 2022
@Mzack9999 Mzack9999 self-assigned this May 9, 2022
@Mzack9999 Mzack9999 linked an issue May 9, 2022 that may be closed by this pull request
-output file gives partial results with a large domains list #190
Closed
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels May 9, 2022
@ehsandeep ehsandeep merged commit 99d5e56 into dev May 10, 2022
@ehsandeep ehsandeep deleted the issue-190-output-file branch May 10, 2022 15:27
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-output file gives partial results with a large domains list
4 participants
@Mzack9999 @ehsandeep @Ice3man543 @LuitelSamikshya