Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating minimum value for retry option #219

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Validating minimum value for retry option #219

merged 2 commits into from
Jul 25, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jul 10, 2022 •
edited
Loading

Description

This PR adds validation to the retry option, ensuring it has a minimum value of 1

Depends on: projectdiscovery/retryabledns#64

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 10, 2022
@Mzack9999 Mzack9999 self-assigned this Jul 10, 2022
@Mzack9999 Mzack9999 linked an issue Jul 10, 2022 that may be closed by this pull request
-retry option is wrong #154
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 12, 2022
@ehsandeep ehsandeep merged commit da123d7 into dev Jul 25, 2022
@ehsandeep ehsandeep deleted the issue-154-retry branch July 25, 2022 16:04
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-retry option is wrong
2 participants
@Mzack9999 @ehsandeep