Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified error message with invalid ports #677

Merged
merged 2 commits into from
Jul 7, 2022
Merged

modified error message with invalid ports #677

merged 2 commits into from
Jul 7, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Jul 1, 2022 •
edited by ehsandeep

This PR modifies the error and warning message with invalid ports.
Test:

echo google.com | ./httpx -p 8000-7000 -v
echo google.com | ./httpx -p 66000 -v
echo https://google.com:777777777 | ./httpx -v

@LuitelSamikshya LuitelSamikshya self-assigned this Jul 1, 2022
@LuitelSamikshya LuitelSamikshya linked an issue Jul 1, 2022 that may be closed by this pull request
httpx Doesn't Error with Invalid Ports #640
Closed
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jul 1, 2022
Mzack9999
Mzack9999 requested changes Jul 4, 2022
View reviewed changes
common/customports/customport.go Outdated Show resolved Hide resolved
runner/options.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Mzack9999
Mzack9999 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ echo scanme.sh | go run . -p 8000-7000 -silent
[FTL] First value of port range should be lower than the last port from your range: [8000, 7000].

@Mzack9999 Mzack9999 requested a review from ehsandeep July 7, 2022 11:49
@ehsandeep ehsandeep merged commit 89cf739 into dev Jul 7, 2022
@ehsandeep ehsandeep deleted the issue-640-error-with-invalid-ports branch July 7, 2022 14:34
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jul 7, 2022
@ehsandeep ehsandeep mentioned this pull request Jul 20, 2022
Closed
@JoshuaMart JoshuaMart mentioned this pull request Jul 28, 2022
Closed
@Mzack9999 Mzack9999 mentioned this pull request Jul 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx Doesn't Error with Invalid Ports
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999