Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing and improving custom ports handling #714

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fixing and improving custom ports handling #714

merged 2 commits into from
Jul 31, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jul 31, 2022 •
edited

Description

This PR does the following:

  • Remove duplicated code introduced in modified error message with invalid ports #677 as the validation is implicitly done while setting the value
  • Add upper limit port value check
  • Restored correct protocol prefix handling (http|https)

Notes

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 31, 2022
@Mzack9999 Mzack9999 self-assigned this Jul 31, 2022
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 31, 2022
@Mzack9999 Mzack9999 linked an issue Jul 31, 2022 that may be closed by this pull request
Ports Flag is not working with scheme #704
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ehsandeep ehsandeep merged commit 21ca262 into dev Jul 31, 2022
@ehsandeep ehsandeep deleted the issue-704-ports-flag branch July 31, 2022 15:24
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 31, 2022
@ehsandeep ehsandeep mentioned this pull request Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ports Flag is not working with scheme
3 participants
@Mzack9999 @ehsandeep @Ice3man543