Propagating error upstream + Random eviction Fix #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
Type: Bug
Mzack9999
changed the title
This was referenced Apr 21, 2023
ShubhamRasal
approved these changes
May 18, 2023
There was a problem hiding this comment.
lgtm 😃
Notes:
- we have to enable, host swap so container can use it directly
- enabling swap may degrade performance, https://docs.docker.com/engine/install/troubleshoot/#kernel-cgroup-swap-limit-capabilities
|
Host swap should be already enabled at OS level. Do we need to add any particular capability/permission to docker or the two conf flags are enough? |
I see, on the servers that swap is not enabled, we may to enable swap before deploying these changes |
ehsandeep
approved these changes
May 19, 2023
|
We are currently running interactsh server with this branch at hackwithautomation.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
atomic.Valuestate change that caused asynchronous server read to face early eviction due to the state beingPollingat iteration check, but turned toIdle/ClosedviaStopPolling()/Close()(Closes investigate and fix correlation id was not found #525)