Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Client Certificate Authentication #1171

Merged
merged 15 commits into from
Oct 30, 2021
Merged

Add Support for Client Certificate Authentication #1171

merged 15 commits into from
Oct 30, 2021

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Oct 21, 2021 •
edited
Loading

Proposed changes

Allow optional arguments for client certificates to be passed to web systems that require that form of authentication.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Closes #1170

@kchason kchason changed the title Client cert auth Add Support for Client Certificate Authentication Oct 21, 2021
@ehsandeep ehsandeep linked an issue Oct 21, 2021 that may be closed by this pull request
Allow Client Authentication #1170
Closed
@ehsandeep ehsandeep requested review from Mzack9999 and Ice3man543 and removed request for Mzack9999 October 21, 2021 19:04
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Oct 24, 2021
Ice3man543
Ice3man543 reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a change to covert tls config logic to a separate function .

@ehsandeep ehsandeep added Status: In-review 🔨 and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Oct 26, 2021
@Ice3man543
Copy link
Member

Thank you for the PR @kchason. Merging it now!

@Ice3man543 Ice3man543 merged commit 331ae0f into projectdiscovery:dev Oct 30, 2021
@kchason kchason deleted the client-cert-auth branch November 14, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ice3man543 Ice3man543 Ice3man543 left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Client Authentication
3 participants
@kchason @Ice3man543 @ehsandeep