Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Checking socks5 proxy before launching a scan #1001 #1225

Merged
merged 25 commits into from
Nov 10, 2021
Merged

feat: Checking socks5 proxy before launching a scan #1001 #1225

merged 25 commits into from
Nov 10, 2021

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Nov 5, 2021 •
edited by ehsandeep
Loading

Proposed changes

  • Proxy validation before running
  • Multiple input support (comma separated or file input)
  • Merged http and socks proxy flag as proxy/p flag.

Before change:

-proxy, -proxy-url string  URL of the HTTP proxy server
-proxy-socks-url string    URL of the SOCKS proxy server

After change:

-p, -proxy string[]      List of HTTP(s)/SOCKS5 proxy to use (comma separated or file input)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

LuitelSamikshya and others added 18 commits October 18, 2021 22:02
@ehsandeep ehsandeep linked an issue Nov 5, 2021 that may be closed by this pull request
Checking socks5 proxy before launching a scan #1001
Closed
@forgedhallpass forgedhallpass changed the title #issue1001 feat: Checking socks5 proxy before launching a scan #1001 Nov 8, 2021
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 10, 2021
@ehsandeep
Copy link
Member

Build fails are unrelated to PR and getting tracked separately - #1240, and was approved before - #1169

@ehsandeep ehsandeep merged commit 0e46d3e into dev Nov 10, 2021
@ehsandeep ehsandeep deleted the #issue1001 branch November 12, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking socks5 proxy before launching a scan
3 participants
@LuitelSamikshya @ehsandeep @parrasajad