New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Checking socks5 proxy before launching a scan #1001 #1169

Merged

LuitelSamikshya merged 13 commits into master from #issue1001

Nov 5, 2021

Contributor

LuitelSamikshya commented Oct 21, 2021 •

edited by ehsandeep

Loading

Proposed changes

Proxy validation before running
Multiple input support (comma separated or file input)
Merged http and socks proxy flag as proxy/p flag.

Before change:

-proxy, -proxy-url string  URL of the HTTP proxy server
-proxy-socks-url string    URL of the SOCKS proxy server

After change:

-p, -proxy string[]      List of HTTP(s)/SOCKS5 proxy to use (comma separated or file input)

Checklist

Pull request is created against the dev branch
All checks passed (lint, unit/integration/regression tests etc.) with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

LuitelSamikshya added 4 commits

October 18, 2021 22:02


          "#issue1001"

4c347e9


          changes for #issue1001

9b1fc34


          minor changes

05409b1


          minor

d32e3f7

LuitelSamikshya linked an issue

that may be closed by this pull request

Checking socks5 proxy before launching a scan #1001

Closed

LuitelSamikshya requested a review from Mzack9999

October 21, 2021 18:49

forgedhallpass reviewed

View reviewed changes

v2/cmd/nuclei/main.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/options.go Outdated Show resolved Hide resolved

forgedhallpass suggested changes

View reviewed changes

Contributor

forgedhallpass left a comment •

edited

Loading

See my comments and the requirements: #1001 (comment). There are also two conflicts that has to be solved.

LuitelSamikshya and others added 3 commits

October 25, 2021 09:12


          flag consolidation and proxy file #issue1001

bda7f53


          readme changes

655dc64


          Merge branch 'master' into #issue1001

60a3b31

forgedhallpass reviewed

View reviewed changes

v2/cmd/nuclei/main.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/cmd/nuclei/main.go Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass suggested changes

View reviewed changes

Contributor

forgedhallpass left a comment •

edited

Loading

Please see my comments and resolve the conversations when you're done.

LuitelSamikshya added 2 commits

October 28, 2021 22:00


          review changes

a63bcbc


          Merge branch '#issue1001' of https://github.com/projectdiscovery/nuclei…

984e588

… into #issue1001

forgedhallpass reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/pkg/types/types.go Outdated Show resolved Hide resolved


          enviroment variable changes

076d623

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

forgedhallpass reviewed

View reviewed changes

v2/internal/runner/proxy.go Outdated Show resolved Hide resolved

LuitelSamikshya added 2 commits

November 2, 2021 22:19


          review comment changes

6237b3e


          review changes

6bf2f23

forgedhallpass changed the title ~~#issue1001~~ feat: Checking socks5 proxy before launching a scan #1001

forgedhallpass reviewed

View reviewed changes

v2/pkg/protocols/http/httpclientpool/clientpool.go Outdated Show resolved Hide resolved

forgedhallpass approved these changes

View reviewed changes

Contributor

forgedhallpass left a comment

The PR looks much cleaner now 👍 The PR should be squashed then merged to not pollute the history.


          removed commented out code

befac19

LuitelSamikshya merged commit c125df4 into master

ehsandeep added a commit that referenced this pull request


          Revert "feat: Checking socks5 proxy before launching a scan #1001 (#1169

348d86d

)"

This reverts commit c125df4.

ehsandeep mentioned this pull request

Revert "feat: Checking socks5 proxy before launching a scan #1001" #1224

Merged

ehsandeep removed a link to an issue

Checking socks5 proxy before launching a scan #1001

Closed

ehsandeep added a commit that referenced this pull request


          Revert "feat: Checking socks5 proxy before launching a scan #1001 (#1169

89c6e76

)"

This reverts commit c125df4.

ehsandeep mentioned this pull request

feat: Checking socks5 proxy before launching a scan #1001 #1225

Merged

7 tasks

ehsandeep removed the request for review from Mzack9999

November 10, 2021 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet