Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for clustering within workflow #1255

Merged
merged 4 commits into from
Nov 21, 2021
Merged

Adding support for clustering within workflow #1255

merged 4 commits into from
Nov 21, 2021

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Nov 15, 2021 •
edited

Proposed changes

This PR adds support for same-level templates clustering within single workflows

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes - (errors are fixed in dev)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999
Adding support for clustering within workflow
e019a57 
works only on same level templates
@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 15, 2021
@Mzack9999 Mzack9999 self-assigned this Nov 15, 2021
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 16, 2021
@Mzack9999 Mzack9999 linked an issue Nov 16, 2021 that may be closed by this pull request
Support for request clustering in workflows #508
Closed
Ice3man543
Ice3man543 approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 21, 2021
@ehsandeep ehsandeep merged commit ca9676f into dev Nov 21, 2021
@ehsandeep ehsandeep deleted the issue-508-workflow-clustering branch November 21, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for request clustering in workflows
3 participants
@Mzack9999 @ehsandeep @Ice3man543