Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1220: no ip returned for dialers #1273

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix #1220: no ip returned for dialers #1273

merged 1 commit into from
Nov 23, 2021

Conversation

Ice3man543
Copy link
Member

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 mentioned this pull request Nov 22, 2021
Closed
@p-l-
Copy link

p-l- commented Nov 22, 2021

I have tested this patch. It works and does fix #1220, for both HTTP and non-HTTP templates!

Thanks a lot, and sorry for not having been able to find the issue myself.

@forgedhallpass forgedhallpass linked an issue Nov 22, 2021 that may be closed by this pull request
Expose IP information of the hostname in the JSON output #1220
Closed
@Ice3man543 Ice3man543 merged commit 1851e37 into dev Nov 23, 2021
@Ice3man543 Ice3man543 deleted the fixed-missing-ip branch November 23, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose IP information of the hostname in the JSON output
2 participants
@Ice3man543 @p-l-