Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional variables for network + simplified logic #1282

Merged
merged 9 commits into from
Nov 30, 2021
Merged

Added additional variables for network + simplified logic #1282

merged 9 commits into from
Nov 30, 2021

Conversation

Ice3man543
Copy link
Member

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

LuitelSamikshya and others added 6 commits November 5, 2021 09:21
@LuitelSamikshya
feat: Checking socks5 proxy before launching a scan #1001 (#1169)
c125df4 
* "#issue1001"

* changes for #issue1001

* minor changes

* minor

* flag consolidation and proxy file #issue1001

* readme changes

* review changes

* enviroment variable changes

* review comment changes

* review changes

* removed commented out code
@ehsandeep
Revert "feat: Checking socks5 proxy before launching a scan #1001 (#1169
89c6e76 
)"

This reverts commit c125df4.
@ehsandeep
Revert "feat: Checking socks5 proxy before launching a scan #1001 (#1169
348d86d 
)"

This reverts commit c125df4.
@ehsandeep
Merge pull request #1224 from projectdiscovery/revert-1169-#issue1001
9a55fcd 
Revert "feat: Checking socks5 proxy before launching a scan #1001"
@ehsandeep
Merge branch 'master' of https://github.com/projectdiscovery/nuclei
37865e4
@Ice3man543
Added additional variables for network + simplified logic
6c819d7
@Ice3man543 Ice3man543 linked an issue Nov 23, 2021 that may be closed by this pull request
Additional global variable support to network protocol #1205
Closed
@Ice3man543 Ice3man543 self-assigned this Nov 23, 2021
@Ice3man543 Ice3man543 added the Status: In Progress This issue is being worked on, and has someone assigned. label Nov 23, 2021
@Ice3man543 Ice3man543 removed a link to an issue Nov 23, 2021
Additional global variable support to network protocol #1205
Closed
@Ice3man543 Ice3man543 linked an issue Nov 23, 2021 that may be closed by this pull request
Additional global variable support to network protocol #1205
Closed
@ehsandeep ehsandeep changed the base branch from master to dev November 27, 2021 23:03
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 27, 2021
Mzack9999
Mzack9999 requested changes Nov 29, 2021
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd suggest replacing {{Hostname}} with {{Host}}

@ehsandeep ehsandeep merged commit be66166 into dev Nov 30, 2021
@ehsandeep ehsandeep deleted the network-vars branch November 30, 2021 06:40
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 requested changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional global variable support to network protocol
4 participants
@Ice3man543 @ehsandeep @Mzack9999 @LuitelSamikshya