Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CVE annotate crash #1407

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Fixing CVE annotate crash #1407

merged 1 commit into from
Dec 20, 2021

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Dec 20, 2021 •
edited
Loading

Proposed changes

This PR fixes the cve-annotate commands crash because of wrong variable name

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 20, 2021
@Mzack9999 Mzack9999 self-assigned this Dec 20, 2021
@Mzack9999 Mzack9999 linked an issue Dec 20, 2021 that may be closed by this pull request
panic: runtime error: index out of range [0] with length 0 (cve-annotate) #1405
Closed
@Mzack9999
Copy link
Member Author

The crash is not happening anymore:

$ ./cve-annotate -i ./cves/ -d .
2021/12/20 12:38:53 Could not fetch cve CVE-2000-0114: invalid CVE ID: CVE-2000-0114
Wrote updated template to /Users/user/go/src/github.com/projectdiscovery/nuclei-templates/cves/2021/CVE-2021-45043.yaml
Wrote updated template to /Users/user/go/src/github.com/projectdiscovery/nuclei-templates/cves/2021/CVE-2021-44848.yaml
Wrote updated template to /Users/user/go/src/github.com/projectdiscovery/nuclei-templates/cves/2021/CVE-2021-44228.yaml
Adjusting severity for /Users/user/go/src/github.com/projectdiscovery/nuclei-templates/cves/2021/CVE-2021-40856.yaml from medium=>high (7.50)
Wrote updated template to /Users/user/go/src/github.com/projectdiscovery/nuclei-templates/cves/2021/CVE-2021-40856.yaml

@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Dec 20, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 20, 2021
@ehsandeep ehsandeep merged commit c1b55d0 into dev Dec 20, 2021
@ehsandeep ehsandeep deleted the issue-1405-cve-annotate-crash branch December 20, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: runtime error: index out of range [0] with length 0 (cve-annotate)
3 participants
@Mzack9999 @ehsandeep @Ice3man543