Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing 307/308 follow redirects with empty body #1446

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fixing 307/308 follow redirects with empty body #1446

merged 2 commits into from
Jan 4, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 2, 2022 •
edited
Loading

Proposed changes

This PR allows the http engine to follow temporary redirects with status code 307/308 with empty body

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 2, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 2, 2022
@Mzack9999 Mzack9999 linked an issue Jan 2, 2022 that may be closed by this pull request
307 Temporary Redirect not working #810
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 2, 2022
Ice3man543
Ice3man543 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit 8414ee1 into dev Jan 4, 2022
@ehsandeep ehsandeep deleted the issue-810-redirect-with-307 branch January 4, 2022 16:22
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 4, 2022
@ehsandeep ehsandeep mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

307 Temporary Redirect not working
3 participants
@Mzack9999 @ehsandeep @Ice3man543