Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interactsh additional variables support #1468

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Jan 10, 2022

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 self-assigned this Jan 10, 2022
@Ice3man543 Ice3man543 added the Status: In Progress This issue is being worked on, and has someone assigned. label Jan 10, 2022
@Ice3man543 Ice3man543 linked an issue Jan 10, 2022 that may be closed by this pull request
2 tasks
@Ice3man543 Ice3man543 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jan 10, 2022
@Ice3man543 Ice3man543 linked an issue Jan 12, 2022 that may be closed by this pull request
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crash when using -ni flag.

./nuclei -ni -t cves/ -u http://0.0.0.0:52190
panic: runtime error: slice bounds out of range [:-1]

goroutine 117 [running]:
github.com/projectdiscovery/nuclei/v2/pkg/protocols/common/interactsh.(*Client).MakePlaceholders(0x140003540e0, {0x140011503e0, 0x1, 0x1}, 0x140017f0c60)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/common/interactsh/interactsh.go:260 +0x20c
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*Request).executeRequest(0x14001b0c000, {0x140038061c8, 0x14}, 0x140031ff0e0, 0x140030d6ff0, 0x1, 0x14004339c58, 0x1)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/request.go:537 +0x1f00
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*Request).ExecuteWithResults.func1({0x1400022ed80, 0x85}, 0x0, 0x140030d6fc0)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/request.go:262 +0x31c
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*Request).ExecuteWithResults(0x14001b0c000, {0x140038061c8, 0x14}, 0x140030d6fc0, 0x140030d6ff0, 0x140030d7050)
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/request.go:315 +0x280
github.com/projectdiscovery/nuclei/v2/pkg/protocols/common/executer.(*Executer).Execute(0x14001bc2080, {0x140038061c8, 0x14})
	/Users/geekboy/Github/nuclei/v2/pkg/protocols/common/executer/executer.go:68 +0x1c4
github.com/projectdiscovery/nuclei/v2/pkg/core.(*Engine).executeModelWithInput.func2.1(0x140036c5a28, 0x1400061b5b0, 0x3, 0x14000756420, 0x1400276c540, 0x14000695a48, 0x0, 0x0, {0x140038061c8, 0x14})
	/Users/geekboy/Github/nuclei/v2/pkg/core/execute.go:141 +0xd8
created by github.com/projectdiscovery/nuclei/v2/pkg/core.(*Engine).executeModelWithInput.func2
	/Users/geekboy/Github/nuclei/v2/pkg/core/execute.go:128 +0x5f0

@ehsandeep ehsandeep merged commit 2432638 into dev Jan 13, 2022
@ehsandeep ehsandeep deleted the interact-variables branch January 13, 2022 07:52
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
3 participants