Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed stats calculation for payloads in http base request #1494

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fixed stats calculation for payloads in http base request #1494

merged 1 commit into from
Jan 20, 2022

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Jan 16, 2022 •
edited by Mzack9999

Proposed changes

Closes #1402

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 self-assigned this Jan 16, 2022
@Ice3man543 Ice3man543 linked an issue Jan 16, 2022 that may be closed by this pull request
Incorrect Stats Output for some templates #1402
Closed
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 16, 2022
Mzack9999
Mzack9999 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ go run . -si 1 -t t.yaml -u http://localhost:8000 -stats
...
[0:00:00] | Templates: 1 | Hosts: 1 | RPS: 168 | Matched: 0 | Errors: 0 | Requests: 5/5 (100%)
[INF] No results found. Better luck next time!

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 19, 2022
@ehsandeep ehsandeep merged commit 956442f into dev Jan 20, 2022
@ehsandeep ehsandeep deleted the fix-progress-calculation-http branch January 20, 2022 10:04
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Stats Output for some templates
3 participants
@Ice3man543 @ehsandeep @Mzack9999