Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing concurrent read/write map #1989

Merged
merged 1 commit into from
May 17, 2022
Merged

Fixing concurrent read/write map #1989

merged 1 commit into from
May 17, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 12, 2022 •
edited

Proposed changes

This PR fixes the concurrent map r/w issue mentioned in #1914

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Example

echo https://192.168.1.1 | go run -race . # then hit ctrl+c

@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels May 12, 2022
@Mzack9999 Mzack9999 self-assigned this May 12, 2022
@Mzack9999 Mzack9999 linked an issue May 12, 2022 that may be closed by this pull request
fatal error: concurrent map iteration and map write #1914
Closed
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels May 12, 2022
@ehsandeep ehsandeep merged commit 184f3fd into dev May 17, 2022
@ehsandeep ehsandeep deleted the issue-1914-map-concurrent-rw branch May 17, 2022 09:08
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map iteration and map write
3 participants
@Mzack9999 @ehsandeep @LuitelSamikshya