Significant refactor around the input to type conversion #3007

vzamanillo · 2022-12-08T20:02:47Z

Proposed changes

Significant refactor around the input to type conversion for clarity and dedup.

Pull request is created against the dev branch
All checks passed (lint, unit/integration/regression tests etc.) with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

…and dedup.

v2/pkg/input/input.go

typeHostWithOptionalPort return the host raw input value if has not port

Víctor Zamanillo added 2 commits December 8, 2022 21:00

Significant refactor around the input to type conversion for clarity …

5f02282

…and dedup.

Better typeHostWithOptionalPort test

c97c3ac

Mzack9999 self-requested a review December 12, 2022 20:23

Mzack9999 requested changes Dec 12, 2022

View reviewed changes

v2/pkg/input/input.go Outdated Show resolved Hide resolved

v2/pkg/input/input.go Show resolved Hide resolved

Removed else branch

bbee2ee

typeHostWithOptionalPort return the host raw input value if has not port

vzamanillo requested a review from Mzack9999 December 13, 2022 10:47

using helpers

aed709b

Mzack9999 approved these changes Dec 13, 2022

View reviewed changes

Mzack9999 merged commit 221cd7b into projectdiscovery:dev Dec 13, 2022

vzamanillo deleted the input-transform-refactor branch December 13, 2022 13:24