Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace break line characters with HTML notation when exporting to markdown #3014

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Replace break line characters with HTML notation when exporting to markdown #3014

merged 3 commits into from
Dec 15, 2022

Conversation

vzamanillo
Copy link
Contributor

@vzamanillo vzamanillo commented Dec 10, 2022 •
edited

Proposed changes

Fixes #2997

imagen

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep requested a review from sullo December 10, 2022 12:48
@ehsandeep ehsandeep linked an issue Dec 11, 2022 that may be closed by this pull request
Markdown Style Broken with Multiline YAML syntax #2997
Closed
@Mzack9999 Mzack9999 self-requested a review December 14, 2022 21:22
Mzack9999
Mzack9999 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -
image

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 14, 2022
@ehsandeep ehsandeep merged commit fd59841 into projectdiscovery:dev Dec 15, 2022
@vzamanillo vzamanillo deleted the issue-2997-broken-markdown branch December 15, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@sullo sullo Awaiting requested review from sullo

Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown Style Broken with Multiline YAML syntax
3 participants
@vzamanillo @ehsandeep @Mzack9999