Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanallip handle edge cases #3080

Merged
merged 7 commits into from
Dec 24, 2022
Merged

scanallip handle edge cases #3080

merged 7 commits into from
Dec 24, 2022

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Dec 23, 2022

Proposed changes

  • ScanAllIPs now handles edgecase urls
  • Improved error message

closes #3078

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar
Copy link
Member Author

go run .  -sa -id tech-detect -l domains.txt

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.8.4-dev

		projectdiscovery.io

[INF] Using Nuclei Engine 2.8.4-dev (development)
[INF] Using Nuclei Templates 9.3.2 (latest)
[INF] Templates added in last update: 57
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 8
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/somepath
[tech-detect:cloudflare] [http] [info] https://hackerone.com/home
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/
[tech-detect:cloudflare] [http] [info] https://hackerone.com/?with=param
[tech-detect:cloudflare] [http] [info] http://hackerone.com:80/?with=param
[tech-detect:cloudflare] [http] [info] https://hackerone.com/
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/somepath
[tech-detect:cloudflare] [http] [info] https://hackerone.com/?with=param
[tech-detect:cloudflare] [http] [info] http://hackerone.com:80/?with=param

@tarunKoyalwar
Copy link
Member Author

tarunKoyalwar commented Dec 23, 2022

Verified with following targets

https://hackerone.com/
https://hackerone.com:443/
https://hackerone.com:443/somepath
http://hackerone.com:80/?with=param
hackerone.com/home
hackerone.com:443/path

@tarunKoyalwar tarunKoyalwar self-assigned this Dec 23, 2022
@tarunKoyalwar tarunKoyalwar linked an issue Dec 23, 2022 that may be closed by this pull request
@tarunKoyalwar tarunKoyalwar marked this pull request as draft December 23, 2022 13:11
@tarunKoyalwar
Copy link
Member Author

$  go run .  -sa  -id tech-detect -l ~/test/domains.txt -silent                             
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/path
[tech-detect:cloudflare] [http] [info] https://hackerone.com/
[tech-detect:cloudflare] [http] [info] https://hackerone.com/home
[tech-detect:cloudflare] [http] [info] https://hackerone.com/?with=param
[tech-detect:cloudflare] [http] [info] http://hackerone.com:80/?with=param
[tech-detect:cloudflare] [http] [info] https://hackerone.com/?with=param
[tech-detect:cloudflare] [http] [info] http://hackerone.com:80/?with=param
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/somepath
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/somepath
[tech-detect:cloudflare] [http] [info] https://hackerone.com/home
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/path
[tech-detect:cloudflare] [http] [info] https://hackerone.com/
[tech-detect:cloudflare] [http] [info] https://hackerone.com:443/

@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review December 23, 2022 14:53
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./nuclei -sa -id tech-detect -u https://www.hackerone.com:443

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.8.4-dev

		projectdiscovery.io

[INF] Using Nuclei Engine 2.8.4-dev (development)
[INF] Using Nuclei Templates 9.3.2 (latest)
[INF] Templates added in last update: 57
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 2
[tech-detect:jsdelivr] [http] [info] https://www.hackerone.com:443
[tech-detect:react] [http] [info] https://www.hackerone.com:443
[tech-detect:google-tag-manager] [http] [info] https://www.hackerone.com:443
[tech-detect:cloudflare] [http] [info] https://www.hackerone.com:443
[tech-detect:jsdelivr] [http] [info] https://www.hackerone.com:443
[tech-detect:react] [http] [info] https://www.hackerone.com:443
[tech-detect:google-tag-manager] [http] [info] https://www.hackerone.com:443
[tech-detect:cloudflare] [http] [info] https://www.hackerone.com:443

@ehsandeep ehsandeep merged commit aee0870 into dev Dec 24, 2022
@ehsandeep ehsandeep deleted the issue-3078-scanallip branch December 24, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to scan all ips reverting to default <nil>
4 participants