Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip scanallip if input is ip #3186

Merged
merged 3 commits into from
Jan 11, 2023
Merged

skip scanallip if input is ip #3186

merged 3 commits into from
Jan 11, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Jan 11, 2023

Proposed changes

  • Adds Condition check and scanallips is skipped if given input is ip

closes #3185

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 linked an issue Jan 11, 2023 that may be closed by this pull request
@tarunKoyalwar tarunKoyalwar self-assigned this Jan 11, 2023
@tarunKoyalwar
Copy link
Member Author

Changes

  • removes defer ratelimit.Stop() which caused infinite wait
  • adds urlutil.ParseWithSchema to parse URL

@tarunKoyalwar
Copy link
Member Author

$ ./nuclei -uc  -uq 'ssl:"uber.com"' -id tech-detect   

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.8.6

		projectdiscovery.io

[INF] Running uncover query against: shodan
[INF] Using Nuclei Engine 2.8.6 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 200
[INF] Running httpx on input host
[INF] Found 200 URL from httpx
[tech-detect:cloudflare] [http] [info] https://104.17.141.8:2087
[tech-detect:cloudflare] [http] [info] https://104.17.177.5:8443
[tech-detect:cloudflare] [http] [info] https://104.17.177.5:2083
[tech-detect:cloudflare] [http] [info] https://104.16.55.17:443
[tech-detect:cloudflare] [http] [info] https://104.17.141.8:2083
[tech-detect:cloudflare] [http] [info] https://104.18.252.218:2083
[tech-detect:cloudflare] [http] [info] https://104.16.55.17:8443
[tech-detect:cloudflare] [http] [info] https://104.18.253.218:443
[tech-detect:cloudflare] [http] [info] https://104.16.54.17:443
[tech-detect:cloudflare] [http] [info] https://104.17.12.50:2087
[tech-detect:cloudflare] [http] [info] https://104.17.178.5:443
[tech-detect:akamai] [http] [info] https://104.114.155.39:443
[tech-detect:akamai] [http] [info] https://104.120.153.94:443
[tech-detect:akamai] [http] [info] https://104.71.75.58:443
[tech-detect:akamai] [http] [info] https://104.67.175.201:443
[tech-detect:akamai] [http] [info] https://104.69.182.78:443
[tech-detect:akamai] [http] [info] https://104.119.150.236:443
[tech-detect:akamai] [http] [info] https://104.66.189.165:443
....

@tarunKoyalwar
Copy link
Member Author

gh actions integration test seems like false positive works locally !!

v2/pkg/core/inputs/hybrid/hmap.go Outdated Show resolved Hide resolved
v2/pkg/core/inputs/hybrid/hmap.go Outdated Show resolved Hide resolved
v2/pkg/utils/utils_test.go Show resolved Hide resolved
@ehsandeep ehsandeep merged commit e899afa into dev Jan 11, 2023
@ehsandeep ehsandeep deleted the issue-3185-scanallips branch January 11, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanAllIps: failed to parse hostname when using uncover query
3 participants