Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using retryablehttp for templates loading #3291

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Using retryablehttp for templates loading #3291

merged 2 commits into from
Feb 9, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Feb 9, 2023 •
edited

Proposed changes

Using retryablehttp instead of net.http with tls verify enabled by default.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep this might fix the tls loading error (hopefully)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 9, 2023
@Mzack9999 Mzack9999 self-assigned this Feb 9, 2023
@Mzack9999 Mzack9999 marked this pull request as draft February 9, 2023 07:29
@Mzack9999 Mzack9999 marked this pull request as ready for review February 9, 2023 11:25
@ehsandeep ehsandeep merged commit 454a883 into dev Feb 9, 2023
@ehsandeep ehsandeep deleted the bugfix-compile-from-remote branch February 9, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mzack9999 @ehsandeep