Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3055 protocol name #3425

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Issue 3055 protocol name #3425

merged 6 commits into from
Mar 20, 2023

Conversation

ShubhamRasal
Copy link
Contributor

@ShubhamRasal ShubhamRasal commented Mar 14, 2023

  • fix test

@ShubhamRasal ShubhamRasal marked this pull request as draft March 14, 2023 16:03
@ShubhamRasal ShubhamRasal linked an issue Mar 14, 2023 that may be closed by this pull request
@ShubhamRasal ShubhamRasal self-assigned this Mar 15, 2023
@ShubhamRasal ShubhamRasal marked this pull request as ready for review March 16, 2023 08:04
tarunKoyalwar

This comment was marked as resolved.

tarunKoyalwar and others added 2 commits March 16, 2023 17:51
- New variables are not used in lib code
@tarunKoyalwar tarunKoyalwar self-requested a review March 20, 2023 19:05
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit a0ccc83 into dev Mar 20, 2023
@ehsandeep ehsandeep deleted the issue-3055-protocol-name branch March 20, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template protocol attribute name update
3 participants