-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing ccache with generic gcache #3523
Conversation
coverting this to draft since there seems to be another deadlock issue in macOS integration test |
@Mzack9999 @ehsandeep , interactsh related integrations tests seems to be uncertain especially with gh actions . sometimes locally I was also getting failed ^ tests .
$ for i in {1..10}; do; ./integration-test -protocol interactsh; done 1 ↵
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
[✓] Test "http/default-matcher-condition.yaml" passed!
[✓] Test "http/interactsh-stop-at-first-match.yaml" passed!
[✓] Test "http/interactsh.yaml" passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
interactsh integration test fails after erroring out 3 times in a row . I think it is safe to assume something is wrong with macOS runner https://github.com/projectdiscovery/nuclei/actions/runs/4699355555/jobs/8332719071?pr=3523 |
Proposed changes
This PR implements the following changes:
Checklist
Notes
.URL()
and their unique id gets registeredTracked at #3437 (the current PR implement preparatory changes)