Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse Github issues instead of creating a new one every time for the same finding #4201

Conversation

mionskowski-form3
Copy link
Contributor

@mionskowski-form3 mionskowski-form3 commented Sep 28, 2023

Proposed changes

Currently the issue reporter on github creates a new issue every time a finding is encountered. This commit changes this behavior and instead keeps one issue per all encounters of a particular finding, where finding is considered a unique title.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works (tested manually as the reporter lacks a test suite)
  • I have added necessary documentation (if appropriate)

@mionskowski-form3 mionskowski-form3 marked this pull request as ready for review September 28, 2023 07:24
v2/cmd/nuclei/issue-tracker-config.yaml Outdated Show resolved Hide resolved
v2/pkg/reporting/trackers/github/github.go Outdated Show resolved Hide resolved
v2/pkg/reporting/trackers/github/github.go Show resolved Hide resolved
@dogancanbakir
Copy link
Member

@mionskowski-form3,
Thanks for the PR! I have left comments for you. Please let me know if you have any questions.

…r the same finding

Currently the issue reporter on github creates a new issue every time a finding is encountered.
This commit changes this behavior and instead keeps one issue per all encounters of a particular finding, where finding is considered a unique title.
@mionskowski-form3
Copy link
Contributor Author

@dogancanbakir thank you for reviewing this. I've addressed your comments.

Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@ehsandeep ehsandeep merged commit 62915a7 into projectdiscovery:dev Oct 3, 2023
10 of 12 checks passed
@ehsandeep ehsandeep removed the request for review from RamanaReddy0M October 3, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants