Merge pull request #140 from projectdiscovery/updater-bug-fix

fix panic on err and version empty
projectdiscovery · Apr 23, 2023 · 41635c6 · 41635c6
2 parents 9261ad8 + 16ddb8e
commit 41635c6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/update/update.go b/update/update.go
@@ -135,7 +135,11 @@ func GetToolVersionCallback(toolName, version string) func() (string, error) {
 			return "", errorutil.NewWithErr(err).Msgf("failed to unmarshal %v", string(body)).WithTag("updater")
 		}
 		if toolDetails.Version == "" {
-			return "", errorutil.NewWithErr(err).Msgf("something went wrong, expected version string but got empty string for GET `%v`", updateURL)
+			msg := fmt.Sprintf("something went wrong, expected version string but got empty string for GET `%v` response `%v`", updateURL, string(body))
+			if err == nil {
+				return "", errorutil.New(msg)
+			}
+			return "", errorutil.NewWithErr(err).Msgf(msg)
 		}
 		return toolDetails.Version, nil
 	}