Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helper for ordered parameters #190

Merged
merged 8 commits into from
Jun 30, 2023
Merged

add helper for ordered parameters #190

merged 8 commits into from
Jun 30, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Jun 28, 2023 •
edited
Loading

Proposed Changes

  • adds OrderedMap to query / preserver order of elements
  • adds OrderedParams to preserve order of query parameters

ref: projectdiscovery/nuclei#3801

@tarunKoyalwar tarunKoyalwar marked this pull request as draft June 28, 2023 17:00
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review June 28, 2023 20:37
@tarunKoyalwar tarunKoyalwar mentioned this pull request Jun 28, 2023
Merged
@tarunKoyalwar
Copy link
Member Author

  • @Mzack9999 we should create minor version release i.e x.Y.z since this is kind of breaking change in some cases

@tarunKoyalwar tarunKoyalwar mentioned this pull request Jun 28, 2023
Merged
4 tasks
@tarunKoyalwar tarunKoyalwar linked an issue Jun 28, 2023 that may be closed by this pull request
Add Ordered Map & Ordered Query Parameters #191
Closed
@tarunKoyalwar tarunKoyalwar mentioned this pull request Jun 28, 2023
Closed
@tarunKoyalwar tarunKoyalwar self-assigned this Jun 28, 2023
Mzack9999
Mzack9999 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mzack9999 Mzack9999 merged commit 6ad94c0 into main Jun 30, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the ordered-query-params branch June 30, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ordered Map & Ordered Query Parameters
2 participants
@tarunKoyalwar @Mzack9999