image build supports vm #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TLDR:
|
|
LGTM. |
CMGS
reviewed
May 5, 2020
| @@ -116,6 +117,11 @@ func (e *Engine) ImageBuild(ctx context.Context, input io.Reader, refs []string) | |||
| return resp.Body, nil | |||
| } | |||
|
|
|||
| // ImageBuildFromExist commits image from running container | |||
| func (e *Engine) ImageBuildFromExist(ctx context.Context, ID, name string) (imageID string, err error) { | |||
| return "", types.ErrEngineNotImplemented | |||
There was a problem hiding this comment.
说起来 docker 是可以做 image from exist 的- -， docker save
There was a problem hiding this comment.
对, docker commit 把容器做成镜像, docker save 把镜像导出成 tar 文件
|
good to go |
atlas-comstock
pushed a commit
to atlas-comstock/core
that referenced
this pull request
May 18, 2020
* add method ImageBuildFromExist into engine interface * add existID in build option * refactor calcium build * implement build from exist * bump version 05.01 * add build option field: build_method * move BuildOption from enginetypes into types * fix ut * add missing image types * build from scm is default method * add errorDetail message when building fails * catch up with ut coverage rate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.