Support type parameter (ordinal/cardinal) in NUMBER() select expressions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type option is simply ignored outside of a select expression, and allows to select based on CLDR plural categories for ordinals (which differ from normal plurals aka cardinal numbers). This is as per (part of) the docs, and per javascript implementation, see projectfluent/fluent#259 -- I haven’t found any definition of NUMBER() in the spec.
Cimbali
changed the title
|
@eemeli you seem to be main committer on this repo (at least recently) and have knowledge of the topic as you opened the linked docs issue, would you have time to take a look? |
eemeli
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type option is simply ignored outside of a select expression, and allows to select based on CLDR plural categories for ordinals (which differ from normal plurals aka cardinal numbers).
This is as per (part* of) the docs, and per javascript implementation, see projectfluent/fluent#259 -- I haven’t found any definition of NUMBER() in the actual spec. Fixes #192.
* Here yes but not here.