Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.2? #588

Closed
GeraldJansen opened this issue Mar 17, 2020 · 11 comments
Closed

Release v3.0.2? #588

GeraldJansen opened this issue Mar 17, 2020 · 11 comments
Assignees

Comments

@GeraldJansen
Copy link
Contributor

It would be good to release a v3.0.2 including bug fix #580.

@mwilck
Copy link
Contributor

mwilck commented Mar 17, 2020

I have nothing against it.
(FTR, the package I created for openSUSE contains this patch already).

Could you send a PR?

@GeraldJansen
Copy link
Contributor Author

Could you send a PR?

Sorry, but I'm not comfortable with the release process. I'd prefer to leave the release management to the maintainers.

@mwilck
Copy link
Contributor

mwilck commented Mar 17, 2020

This how it works - someone creates a PR, and the maintainers will discuss and possibly merge it. You may recall that nobody can push directly to the master repo any more.

But if you'd rather wait for someone else to create the PR, fine with me.

@matthijskooijman
Copy link
Member

Seems like creating a PR for a release is a good job for the maintainers, actually, not so much a "random" contributor would do. I haven't looked at what's involved in a release yet, probably changelog, maybe bumping a version somewhere and once it's merged, tag the resulting commit (I think we can push tags directly, though you can probably also create them through the github releases tab as well).

I can have a look later, gotta run now.

@ederag
Copy link
Collaborator

ederag commented Mar 17, 2020

Checklist: https://github.com/projecthamster/hamster/projects/1#card-27399663
starting after the translation stuff (that part was a stub, not up to date)

@matthijskooijman
Copy link
Member

Probably good to include a fix for #590 as well (which is not merged yet, though).

@ederag
Copy link
Collaborator

ederag commented Apr 29, 2020

Yay ! Last commit Mar 14, we are Apr 29. Let's delay some more ! 😄

@matthijskooijman
Copy link
Member

Yay ! Last commit Mar 14, we are Apr 29. Let's delay some more ! smile

I'm not entirely sure what you mean here. I suspect you're being cynical? If you have alternative proposals, please state them plainly with arguments, so we can have constructive discussions.

@ederag
Copy link
Collaborator

ederag commented Apr 30, 2020

@matthijskooijman
Copy link
Member

Not much more plain, but well. I can probably guess what you mean.

My original thought was that #590 is a very similar problem (with offsets in dates), so it would be good to include that. However, it seems the fix is a little bit more involved, so maybe releasing what we have now might indeed be better than trying to fix #590 first (e.g. rather than spending time fixing that, better spend some time figuring out the release process first).

I'll have a go at preparing a release, probably though a PR, using the checklist @ederag linked.

@GeraldJansen
Copy link
Contributor Author

Thanks and congratulations on the first release made by the new maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants