Desktop and i18n work #559
Conversation
Re-introduce translatable strings, and use the phrases for which we already have translations in existing .po files.
|
Please hold on, Please do not even try to PR the first commit separately, it's good practice to keep the Exec line. |
The 'subst' rule is not necessary any more. Use a rule to create i18n entries in the desktop file instead.
Add a waf configure-time option "--build-i18n". If this option is given, waf will rebuilt the .pot template from po/POTFILES.in, and will recreate all .po files. This happens in the build/ subdirectory. By copying back the .po files from build/po/ to po/, they can be updated in the source tree.
Use a string we already have lots of translations for.
Changes made using the --build-i18n option.
mwilck
force-pushed
the
desktop-and-i18n-work
branch
from
3c07199
to
7e587c4
Compare
|
Pushed again with the removal of the |
|
Some commits look promising, |
Hm, while looking for something else, I noticed #497 earlier today, which seems to remove translations of the desktop file (without really mentioning this in the commit messages, so I'm not sure why). Maybe you @mwilck already know this, but otherwise it might be useful background (haven't looked at this PR at all yet, though). |
|
I noticed that the translations were gone, and I made this PR to add them back. I found it strange to create a 3.0 release with a desktop file without any translations. I'm definitely not an i18n expert. Things have changed a lot in this area, you find notes everywhere that tools that were previously used are now deprecated and out of support. I fiddled around with this for a day or two until the results looked ok-ish to me. Obviously I couldn't review all translations. After @ederag's last comment (Feb 18), I didn't bother any more. @ederag has made some changes to the waf code after this PR that prevent merging it directly. I guess it's fixable with some mechanic changes (variable renames), but it's been 3 months, I've forgotten most of the stuff I did here. |
|
... and no, I don't have slightest idea why these translations had been removed. |
This started out with me realizing that we had no translations in our
.desktopfile. I thought that's not ideal for a desktop program. I tried to figure out how to generate them and stumbled upon the recent move from intltool to gettext, and figured that the.pofiles haven't been updated for quite a while. It was a pretty rough ride because I'm not familiar with either waf or gettext.Eventually I have come up with a way to rebuild the
.pofiles from the current source, and optionally commit them in in git. (That's the big "update translations" commit. I've reviewed thede.pofile and the results seemed reasonable to me). I also added some missing German translations.Please have a look.