Split RepliconTick from resource
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third-party rollback crates need decrement operations. This is why they using their own ticks and convert them back and forth. It's not convenient. Just providing decrement operations to resource would be weird since user should never decrement it. This is why I made `RepliconTick` into a simple struct and use a dedicated resource called `ServerTick` for tracking current simulation tick. See also bevyengine/bevy#13306
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 91.53% 91.19% -0.34%
==========================================
Files 36 37 +1
Lines 2067 2079 +12
==========================================
+ Hits 1892 1896 +4
- Misses 175 183 +8 ☔ View full report in Codecov by Sentry. |
UkoeHB
approved these changes
May 11, 2024
Shatur
added a commit
that referenced
this pull request
May 15, 2024
Shatur
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third-party rollback crates need decrement operations. This is why they using their own ticks and convert them back and forth. It's not convenient.
Just providing decrement operations to resource would be weird since user should never decrement it. This is why I made
RepliconTickinto a simple struct and use a dedicated resource calledServerTickfor tracking current simulation tick.See also bevyengine/bevy#13306