Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins should see non-approved works in admin/admin_sets show view #726

Closed
jcoyne opened this issue Jan 30, 2017 · 10 comments
Closed

Admins should see non-approved works in admin/admin_sets show view #726

jcoyne opened this issue Jan 30, 2017 · 10 comments
Assignees

Comments

@jcoyne
Copy link
Member

jcoyne commented Jan 30, 2017

on this page: /admin/admin_sets/db78tc02w Currently the unapproved work is included in the count, but not shown in the list of works. These should be consistent.

@mjgiarlo
Copy link
Member

@hannahfrost @ggeisler ?

My $0.02 -- I think admins should be able to see them, given what we've said/heard in other tickets: #494 and samvera/hyrax#185 (I thought there was another ticket about admins having access to all works regardless of ACL, but couldn't dig it up in a pinch.)

@ggeisler
Copy link
Contributor

I agree. I think admins should inherit all lower sets of privileges, so that would mean they should see any unapproved work in the repo. (This is also an assumption in the forthcoming mockups for #447.)

I was under the impression that not only could admins see all works, but they can approve and edit them as well. It might be beyond the point of this ticket, but let me know if this isn't the case so I can correct my mental model of how things work.

(Admin Set Admins -- which I think only exist in theory so far -- would similarly have all privileges, but only on the admin set(s) for which they are an Admin Set Admin, if my understanding of the plan is correct.)

@hannahfrost
Copy link

+1 to what @ggeisler has said.

Here is the permissions matrix that we have been working with: https://docs.google.com/spreadsheets/d/1TSZ8CUuq6puwzyJ1Av0aQ798FOQZgzhkn2jaDYyt118/edit#gid=0

You will note that on this doc we use the term "Repository Admin" and "Repository Manager". My understanding is these translate to "superadmin" and "admin" respectively as we have been referring to the roles of late.

Perhaps we need to talk about how to codify our terminology so we are confident in our communications, and also if there are tickets that need to be written (thinking of @mjgiarlo 's comment above).

@hannahfrost
Copy link

@jcoyne Is your question here resolved now?

@mjgiarlo
Copy link
Member

mjgiarlo commented Feb 6, 2017

Ringing @jcoyne

@jcoyne
Copy link
Member Author

jcoyne commented Feb 6, 2017

Yes. Would we want any UI element to show their workflow status (e.g. published/not-published) in that list?

@mjgiarlo
Copy link
Member

mjgiarlo commented Feb 9, 2017

That makes sense to me, @jcoyne, and I believe an earlier mockup of @ggeisler's did have a column for that.

@ggeisler
Copy link
Contributor

@jcoyne I think @mjgiarlo @hannahfrost and I all like the idea of a column ("Status"?) that shows the published state of the work, similar to the mockups in #447, something like "Published" | "In Review".

I think we want to move this ticket out of Design Needed to Ready so let us know if this doesn't answer your question.

@mjgiarlo mjgiarlo changed the title Should admins be able to see non-approved works when they view an admin set? Admins should see non-approved works in admin/admin_sets show view Feb 27, 2017
@laritakr laritakr self-assigned this Mar 15, 2017
laritakr pushed a commit to samvera/hyrax that referenced this issue Mar 17, 2017
laritakr pushed a commit to samvera/hyrax that referenced this issue Mar 22, 2017
samvera/hyku#726
Give admin sets their own work index view partials, which include
a column showing the status of the work.
laritakr pushed a commit to samvera/hyrax that referenced this issue Mar 22, 2017
samvera/hyku#726
Give admin sets their own work index view partials, which include
a column showing the status of the work.
@mjgiarlo
Copy link
Member

@laritakr Should this issue be closed?

@laritakr
Copy link
Collaborator

Yes, this was implemented in Hyrax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants