New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutlitenancy in test #1105
Mutlitenancy in test #1105
Conversation
Our new strictness makes fake tenant accounts inadequate. Trying to fix. |
This will break, but we should push through to make this the default.
These would only affect Travis.
**:singletenant** This is effectively the reverse of `:multitenant`. It is the cheapest way to fix existing tests that would fail under multitenant default. Singletenant tests - Feature test default singletenant - riiif specs are singletenant - appearances_controller_spec.rb - groups_controller_spec.rb That's how all these were written. **faketenant** Specifically tests that don't care about single or multi-tenancy, they just want there to seem like there is a consistent real tenant. Give all controller tests faketenant unlesss otherwise specified Because the tenant is going to be required for basic routing.
Avoid hardcoding paths in the example.
and tenancy-aware
All fixed... except for one failure in "push". |
I restarted the "push" build. In the meantime, here was the one failure:
@atz @jcoyne @cbeer I have seen this one before, but it it usually resolved by restarting the build. That said, do y'all think this is something we should be worrying about? I ask because we have Solr connection issues in demo-land -- maybe they're not connected, though. |
Why can't I get this locally though? |
See #989 where this was all debated over being merged into a branch that was thrown away. But we actually want this.