Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Nil Object Pattern for non-initialized connections. #1147

Merged
merged 2 commits into from May 26, 2017
Merged

Use the Nil Object Pattern for non-initialized connections. #1147

merged 2 commits into from May 26, 2017

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented May 24, 2017

Fixes #1138

@mjgiarlo mjgiarlo merged commit a3c1c6f into master May 26, 2017
@mjgiarlo mjgiarlo deleted the nil_connection branch May 26, 2017 17:00
@atz
Copy link
Contributor

atz commented Jul 20, 2017

This is the wrong solution for the issue at hand and takes us (back) to a situation where switch! is no longer reliable for doing its job. This violates the expectations of Apartment, which are what matters for the behavior of that method.

100% would revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @atz @mjgiarlo