Describing bugs with pending tests #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO: Bug described in issue #609 | ||
| describe "#select" do | ||
| it "should choose a subset of objects in the relationship" do | ||
| pending "method should be interpreted as private" |
There was a problem hiding this comment.
I'm not sure I understand this message. Is the method private now, but should not be? Can you clarify?
There was a problem hiding this comment.
@awead how about changing the description to "method has private visibility" instead of saying "should be ..."
|
@jcoyne Updated PR per your comments. |
jcoyne
added a commit
that referenced
this pull request
Dec 3, 2014
Describing bugs with pending tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks tests related to #540 and #609 as pending.