-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tracking not working when using shift operator on properties? #540
Comments
@jcoyne there's not enough information here for us to proceed. Where is the relevant place in the AF stack? Can you explain the issue more? |
When you shift (<<) onto an AT property, it isn't registered in the changes hash, so a sparql insert isn't created. This is just my suspicion, needs further confirmation. |
@jcoyne I've confirmed it and have a failing test in ActiveFedora |
An issue with ActiveModel::Dirty is affecting the shift operator in ActiveFedora. Until samvera/active_fedora#540 is resolved, we should avoid using it.
so.. afaik, the So, if we really want to get this to work, i think we need some way for Or, we can just tell people to use |
At the developer meeting @no-reply suggested that ActiveModel::Dirty could move into ActiveTriples. That would be a way to fix this. |
i took a minute to look at how that might be implemented and got hung up on the fact that all (except a few) instance methods of |
An issue with ActiveModel::Dirty is affecting the shift operator in ActiveFedora. Until samvera/active_fedora#540 is resolved, we should avoid using it.
An issue with ActiveModel::Dirty is affecting the shift operator in ActiveFedora. Until samvera/active_fedora#540 is resolved, we should avoid using it.
An issue with ActiveModel::Dirty is affecting the shift operator in ActiveFedora. Until samvera/active_fedora#540 is resolved, we should avoid using it.
Failure/Error: expect(f.title).to include("Newer work")
expected ["New work"] to include "Newer work"
./spec/models/generic_file_spec.rb:304:in `block (4 levels) in <top (required)>'
The text was updated successfully, but these errors were encountered: