-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accessible_by is a monkey patch #372
Comments
I think this was following the pattern put forward by cancan: https://github.com/CanCanCommunity/cancancan/blob/fbff9a114ccb76205b164c85a9b2f7d211e95171/lib/cancan/model_adapters/active_record_adapter.rb#L146-L148 |
I think this could be refactored to get rid of at least one of the monkey patches though, but I don't think this feature is something often used, because Fedora is slow, so we typically fulfill this use case by querying only Solr (and not Fedora) |
Two monkey patches, actually:
This is pretty poor form for code that is intended to enact security controls. We're reaching into AF:QueryMethods and declaring that its includers get an additional method with hardcoded permissions levels and
Hydra::AccessControlsEnforcement
.The application of the monkey patches is not controlled by any invocation, and it is not avoidable or reversible.
The text was updated successfully, but these errors were encountered: