Changes to use promises instead of callbacks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renaming Attempt.ts to Utils.ts * Adding bin direectory to .gitignore
| @@ -9,3 +9,5 @@ _ReSharper.*/ | |||
| node_packages/* | |||
| node_modules/* | |||
| lib/*.js | |||
| bin/*.js | |||
There was a problem hiding this comment.
please remove this added line.
Since we use the precompiled approach (typescript is compiled before being packaged) we check in the resulted (after running build) kuduSync.js file.
|
I don't have the background on this. It looks like a huge change, and on the surface, it being "slightly cleaner and a bit more readable" seems like a weak reason. Let's discuss the pros and cons. |
| @@ -1,4 +1,4 @@ | |||
| ///<reference path='attempt.ts'/> | |||
| ///<reference path='Utils.ts'/> | |||
There was a problem hiding this comment.
Interestingly there's a mismatch in the actual file name casing (e.g. FileInfo.ts and the reference reference path='fileInfo.ts'). I'm not sure how this pans out in a OS with case sensitive filenames.
|
Merged in changeset 2dc1c5b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Felt that it was slightly cleaner and a bit more readable. I couldn't get the tests to run though, so this is still work in progress.