Remove support for old settings controller format. Fixes #644

projectkudu · Nov 19, 2014 · f0a8b0f · f0a8b0f
1 parent f55cfb5
commit f0a8b0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 32 deletions.
diff --git a/Kudu.FunctionalTests/SettingsApiFacts.cs b/Kudu.FunctionalTests/SettingsApiFacts.cs
@@ -86,11 +86,9 @@ public void GetAllValues()
                     appManager.SettingsManager.SetValue("y", "2").Wait();
                     appManager.SettingsManager.SetValue("z", "3").Wait();
 
-                    NameValueCollection resultsLegacy = appManager.LegacySettingsManager.GetValues().Result;
                     NameValueCollection results = appManager.SettingsManager.GetValues().Result;
 
                     // Assert
-                    CheckSettings(resultsLegacy);
                     CheckSettings(results);
                 });
             }

diff --git a/Kudu.Services/Settings/SettingsController.cs b/Kudu.Services/Settings/SettingsController.cs
@@ -103,37 +103,9 @@ public HttpResponseMessage Delete(string key)
         /// Get the list of all settings
         /// </summary>
         /// <returns></returns>
-        public HttpResponseMessage GetAll(int version = 1)
+        public HttpResponseMessage GetAll()
         {
-            /*
-            Old format looks like this:
-            [
-                {
-                    Key: "branch",
-                    Value: "master"
-                },
-                {
-                    Key: "foo",
-                    Value: "123"
-                }
-            ]
-
-            New format looks like:
-            {
-                branch: "master",
-                foo: "123"
-            }
-            */
-
-            var values = _settingsManager.GetValues();
-
-            if (version < 2)
-            {
-                var legacyValues = values.Select(pair => new Dictionary<string, string> { { "key", pair.Key }, { "value", pair.Value } });
-                return Request.CreateResponse(HttpStatusCode.OK, legacyValues);
-            }
-
-            return Request.CreateResponse(HttpStatusCode.OK, values);
+            return Request.CreateResponse(HttpStatusCode.OK, _settingsManager.GetValues());
         }
 
         /// <summary>