Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milkdrop 1.4 presets or only some effects render upside down #725

Closed
kblaschke opened this issue Sep 15, 2023 · 0 comments · Fixed by #733
Closed

Milkdrop 1.4 presets or only some effects render upside down #725

kblaschke opened this issue Sep 15, 2023 · 0 comments · Fixed by #733
Assignees
Labels
Milestone

Comments

@kblaschke
Copy link
Member

After the renderer rewrite for 4.1, due to the way how presets need to be rendered to circumvent the Y coordinate flip between DirectX and OpenGL, presets not using any shaders at all will be drawn upside down and not flipped before being displayed. After applying any configured old-school filters, a final draw flipping the image should be performed.

A few presets have mismatching locations for some effects, where custom waves do not match the shape positions while they obviously should. In these occasions it looks like not all effects are correctly drawn properly Y-flipped.

Some presets with this issue can be found in the upside down.zip archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant