allow basemap tiles configuration #127
Conversation
Codecov ReportBase: 78.58% // Head: 79.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 78.58% 79.44% +0.86%
==========================================
Files 8 9 +1
Lines 621 647 +26
Branches 132 137 +5
==========================================
+ Hits 488 514 +26
Misses 116 116
Partials 17 17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mesa_geo/tile_layers.py
Outdated
| Pre-configured map tiles for the background tile layer of Leaflet map. | ||
| """ | ||
|
|
||
| OPEN_STREET_MAP = RasterWebTile( |
There was a problem hiding this comment.
Doesn't xyzservices already have this? https://github.com/geopandas/xyzservices/blob/5390ede63a1b05e9839fb825fc6aca61f2f16df5/xyzservices/data/providers.json#L2-L8
There was a problem hiding this comment.
Yes, but I preferred to have the default value from our own repo, instead of using that from xyzservices.
Shall I remove the MapTiles class completely for now?
There was a problem hiding this comment.
I first need to understand the difference with xyzservices's tiles. If they are the same, I think we shouldn't duplicate it.
There was a problem hiding this comment.
Well, these are exactly the same : )
There was a problem hiding this comment.
In that case, reusing existing ones is better.
There was a problem hiding this comment.
Ok, I'll remove them then.
wang-boyu
force-pushed
the
feat/basemap
branch
from
edc47b4
to
c60d3f9
Compare
wang-boyu
force-pushed
the
feat/basemap
branch
from
c60d3f9
to
9f5b191
Compare
|
LGTM |
Implements #48 and #66.